BUG: Allow string keys with higher resolution than index in PeriodIndex.get_loc #43105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dicristina wants to merge 3 commits into pandas-dev:master from dicristina:period_loc_GH40145

Contributor

dicristina commented Aug 19, 2021

closes BUG: Regression in PeriodIndex.loc string slicing behaviour between 1.0.x and >= 1.1.0 #40145
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

dicristina added 3 commits

August 18, 2021 17:53


          Allow higher frequency strings on PeriodIndex.get_loc

694045a


          Test for new behavior of PeriodIndex.get_loc

08d21dc


          Added whatsnew.

e1601e8

jbrockmendel reviewed

View reviewed changes

pandas/tests/indexes/period/test_indexing.py

-                      with pytest.raises(KeyError, match=key):
-                          with tm.assert_produces_warning(FutureWarning):
-                              idx0.get_value(ser, key)
+                      assert key in idx0

Member

jbrockmendel Aug 23, 2021

i dont think this behavior makes sense

dicristina closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet