Skip to content

TST: refactor count rows in sql test #43083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

TST: refactor count rows in sql test #43083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 25 additions & 21 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,24 @@ def create_and_load_types(conn, types_data: list[dict], dialect: str):
conn.execute(stmt)


def count_rows(conn, table_name: str):
stmt = f"SELECT count(*) AS count_1 FROM {table_name}"
if isinstance(conn, sqlite3.Connection):
cur = conn.cursor()
result = cur.execute(stmt)
else:
from sqlalchemy import text
from sqlalchemy.engine import Engine

stmt = text(stmt)
if isinstance(conn, Engine):
with conn.connect() as conn:
result = conn.execute(stmt)
else:
result = conn.execute(stmt)
return result.fetchone()[0]


@pytest.fixture
def iris_path(datapath):
iris_path = datapath("io", "data", "csv", "iris.csv")
Expand Down Expand Up @@ -415,12 +433,6 @@ class PandasSQLTest:

"""

def _get_exec(self):
if hasattr(self.conn, "execute"):
return self.conn
else:
return self.conn.cursor()

@pytest.fixture
def load_iris_data(self, iris_path):
if not hasattr(self, "conn"):
Expand Down Expand Up @@ -451,14 +463,6 @@ def _check_iris_loaded_frame(self, iris_frame):
assert issubclass(pytype, np.floating)
tm.equalContents(row.values, [5.1, 3.5, 1.4, 0.2, "Iris-setosa"])

def _count_rows(self, table_name):
result = (
self._get_exec()
.execute(f"SELECT count(*) AS count_1 FROM {table_name}")
.fetchone()
)
return result[0]

def _read_sql_iris(self):
iris_frame = self.pandasSQL.read_query("SELECT * FROM iris")
self._check_iris_loaded_frame(iris_frame)
Expand Down Expand Up @@ -487,7 +491,7 @@ def _to_sql(self, test_frame1, method=None):
assert self.pandasSQL.has_table("test_frame1")

num_entries = len(test_frame1)
num_rows = self._count_rows("test_frame1")
num_rows = count_rows(self.conn, "test_frame1")
assert num_rows == num_entries

# Nuke table
Expand Down Expand Up @@ -518,7 +522,7 @@ def _to_sql_replace(self, test_frame1):
assert self.pandasSQL.has_table("test_frame1")

num_entries = len(test_frame1)
num_rows = self._count_rows("test_frame1")
num_rows = count_rows(self.conn, "test_frame1")

assert num_rows == num_entries
self.drop_table("test_frame1")
Expand All @@ -534,7 +538,7 @@ def _to_sql_append(self, test_frame1):
assert self.pandasSQL.has_table("test_frame1")

num_entries = 2 * len(test_frame1)
num_rows = self._count_rows("test_frame1")
num_rows = count_rows(self.conn, "test_frame1")

assert num_rows == num_entries
self.drop_table("test_frame1")
Expand All @@ -554,7 +558,7 @@ def sample(pd_table, conn, keys, data_iter):

assert check == [1]
num_entries = len(test_frame1)
num_rows = self._count_rows("test_frame1")
num_rows = count_rows(self.conn, "test_frame1")
assert num_rows == num_entries
# Nuke table
self.drop_table("test_frame1")
Expand All @@ -570,7 +574,7 @@ def _to_sql_with_sql_engine(self, test_frame1, engine="auto", **engine_kwargs):
assert self.pandasSQL.has_table("test_frame1")

num_entries = len(test_frame1)
num_rows = self._count_rows("test_frame1")
num_rows = count_rows(self.conn, "test_frame1")
assert num_rows == num_entries

# Nuke table
Expand Down Expand Up @@ -695,7 +699,7 @@ def test_to_sql_replace(self, test_frame1):
assert sql.has_table("test_frame3", self.conn)

num_entries = len(test_frame1)
num_rows = self._count_rows("test_frame3")
num_rows = count_rows(self.conn, "test_frame3")

assert num_rows == num_entries

Expand All @@ -707,7 +711,7 @@ def test_to_sql_append(self, test_frame1):
assert sql.has_table("test_frame4", self.conn)

num_entries = 2 * len(test_frame1)
num_rows = self._count_rows("test_frame4")
num_rows = count_rows(self.conn, "test_frame4")

assert num_rows == num_entries

Expand Down