Skip to content

ENH: add integer sheetname support in read_excel #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2013
Merged

ENH: add integer sheetname support in read_excel #4308

merged 1 commit into from
Jul 25, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 20, 2013

closes #4301

@ghost ghost assigned cpcloud Jul 20, 2013
@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

I guess a sheet names as '0' would have to be specified as as actual string to avoid confusion

@cpcloud
Copy link
Member Author

cpcloud commented Jul 20, 2013

yep. i should also add something to the docs acknowledging that and an example

@cpcloud
Copy link
Member Author

cpcloud commented Jul 20, 2013

i'll add a test for that to see how it's handled. not sure how xlrd deals with that

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

you could try to get a stringified first then fall back to positional if it is an integer
not sure if that is more confusing

@cpcloud
Copy link
Member Author

cpcloud commented Jul 20, 2013

so essentially prefer named sheets to indexing where possible

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

on 2nd thought I think passing an int try for index otherwise try named (like u have it)
no ambiguity

@cpcloud
Copy link
Member Author

cpcloud commented Jul 20, 2013

@jreback ot what is the Bounty label for?

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

Bounty label?

@cpcloud
Copy link
Member Author

cpcloud commented Jul 20, 2013

there's an issue label called "Bounty", just wondering what that's for...

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

no idea
maybe a standard label that git creates?
like bounty on stackoverflow

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

or it could be the quicker picker upper :)

@cpcloud
Copy link
Member Author

cpcloud commented Jul 21, 2013

😆

@ccverg
Copy link

ccverg commented Jul 22, 2013

@cpcloud @jreback it's the label for issues with bounties on Bountysource ;) (https://www.bountysource.com/trackers/50755-pydata-pandas)

@cpcloud
Copy link
Member Author

cpcloud commented Jul 22, 2013

@ccvergara oh cool didn't know about that thanks!

@cpcloud
Copy link
Member Author

cpcloud commented Jul 25, 2013

@jreback any last words?

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

I think u need to rebase as release notes
looks older

@cpcloud
Copy link
Member Author

cpcloud commented Jul 25, 2013

@jreback good 2 go?

**Bug Fixes**


pandas 0.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still looks like it has a conflict here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry! didn't see that there was a repeat

cpcloud added a commit that referenced this pull request Jul 25, 2013
ENH: add integer sheetname support in read_excel
@cpcloud cpcloud merged commit 5d2b85f into pandas-dev:master Jul 25, 2013
@cpcloud cpcloud deleted the read-excel-page-number-sheet-name branch July 25, 2013 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: pandas.read_excel should be able to accept a page number or string name in the sheetname argument
3 participants