-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: add integer sheetname support in read_excel #4308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add integer sheetname support in read_excel #4308
Conversation
I guess a sheet names as '0' would have to be specified as as actual string to avoid confusion |
yep. i should also add something to the docs acknowledging that and an example |
i'll add a test for that to see how it's handled. not sure how |
you could try to get a stringified first then fall back to positional if it is an integer |
so essentially prefer named sheets to indexing where possible |
on 2nd thought I think passing an int try for index otherwise try named (like u have it) |
@jreback ot what is the Bounty label for? |
Bounty label? |
there's an issue label called "Bounty", just wondering what that's for... |
no idea |
or it could be the quicker picker upper :) |
😆 |
@cpcloud @jreback it's the label for issues with bounties on Bountysource ;) (https://www.bountysource.com/trackers/50755-pydata-pandas) |
@ccvergara oh cool didn't know about that thanks! |
@jreback any last words? |
I think u need to rebase as release notes |
@jreback good 2 go? |
**Bug Fixes** | ||
|
||
|
||
pandas 0.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still looks like it has a conflict here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry! didn't see that there was a repeat
ENH: add integer sheetname support in read_excel
closes #4301