BENCH: Add pyarrow to env #43071
Merged
BENCH: Add pyarrow to env #43071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm thanks @lithomas1 yeah this should also help with the string functions, we should have the parameterizations already. cc @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while I was benchmarking the pyarrow csv reader that I am planning to PR soon, which was erroring with an ImportError for pyarrow. Anyone know if this is the right patch? (It works correctly for me afterwards, however I am curious as to how ArrowStringArray was getting benchmarked)
pytest also should be removable I think. (there really shouldn't be any reason why we are benchmarking that)
cc @simonjayhawkins @TomAugspurger