Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH:included anti join functionality #43056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH:included anti join functionality #43056
Changes from 25 commits
fba0bb5
53fd41d
627c31e
448373b
4dd802d
3b17c59
6e3d1a4
6427f09
86ddac9
84294e4
43ae0a1
c36705c
951406a
db80abf
d93c0ac
90af576
80ce02e
79bbbb9
ee7cc16
76cd5c6
d358efc
14d0d4c
3fe64f4
fc50027
aba9a30
411bcaa
417ea13
09426c6
b6e72aa
8338a48
cc6c8ea
f33fe48
74e172b
594f80a
f395cbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok with this being a method on _MergeOperation but it should have NO side effects, e.g. simply return left, right and assign at this level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if I understand what you mean by, being a method on _MergeOperation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to execute in the
get_result()
portion, NOT during validation. validation shouldn't dot he actual computation.IOW during _get_join_info could dispatch based on
how
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the actual calculation is still happening in
get_result()
.I have just changed the configuration of
left
,right
andhow
to utilise the already existing joining methods. E.g. Foranti_left
I have changed theleft
,right
andhow
toleft
such thatleft join
would give the resultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jreback - wondering if you got a chance to look at this? and if this implementation is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no the implementation is quite convoluted
i am not sure how to fix what u have here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest these comments are obvious, as you said. it was more the general concept that you could have expanded in the main docstring, why you have implemented it this way and what is the advantage. Just in case you come back to look at it after two years, or another developer comes in and tries to figure out what you are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comments in merge.py looks sufficient to me. But again, I wrote it and a second pair of eyes can give a fresh perspective.
Do you think the logic in merge.py is too difficult to follow? (if you could point to any specific portion)