Skip to content

TST: refactor types table in SQL test #43040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

fangchenli
Copy link
Member

xref #40686

@fangchenli fangchenli added Testing pandas testing functions or related to the test suite IO SQL to_sql, read_sql, read_sql_query labels Aug 14, 2021
@jreback jreback added this to the 1.4 milestone Aug 16, 2021

@pytest.fixture
def types_data_frame(types_data):
dtypes = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "DateColWithTz" get added here later for postgres?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used for a sqlite test.

@jreback jreback merged commit 2753975 into pandas-dev:master Aug 17, 2021
@jreback
Copy link
Contributor

jreback commented Aug 17, 2021

thanks @fangchenli

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@fangchenli fangchenli deleted the sql-type-table branch November 18, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants