Skip to content

Testing to_datetime, converting none to NaT #43006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Testing to_datetime, converting none to NaT #43006

wants to merge 4 commits into from

Conversation

ryangilmour
Copy link
Contributor

@ryangilmour ryangilmour commented Aug 12, 2021 •
edited
Loading

Addition of a test. Bug was fixed for #35888 somewhere in the main branch, this test just adds a unit test.

@ryangilmour ryangilmour marked this pull request as ready for review August 12, 2021 23:11
@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Aug 16, 2021
@mroeschke
Copy link
Member

Looks like there are linting errors. Please ensure precommit is installed and run on your commits to catch these: https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#pre-commit

@ryangilmour ryangilmour mentioned this pull request Aug 20, 2021
Closed
3 tasks
@ryangilmour ryangilmour marked this pull request as draft August 20, 2021 14:18
@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Datetime Datetime data dtype labels Aug 21, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 21, 2021
@mroeschke
Copy link
Member

Thanks for the PR, but appears this PR has gone stale. Closing for now, but if interested in continuing please merge master and ping and we can reopen.

@mroeschke mroeschke closed this Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Stale Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pd.to_datetime() raises InvalidIndexError with Null-like arguments
4 participants
@ryangilmour @mroeschke @jreback @simonjayhawkins