Skip to content

ENH: expose ujson precise_float argument on decode #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2013

Conversation

Komnomnomnom
Copy link
Contributor

The new version of ujson takes a boolean precise_float argument when decoding, this should be exposed when decoding pandas objects.

@jreback
Copy link
Contributor

jreback commented Jul 19, 2013

I can update the docs about precise_float (when you say ready for merge)....

how shall I describe this?

@Komnomnomnom
Copy link
Contributor Author

Doh, I never think about the docs, ujson describe it as

precise_float

Set to enable usage of higher precision (strtod) function when decoding string to double values. Default is to use fast but less precise builtin functionality

@jreback
Copy link
Contributor

jreback commented Jul 19, 2013

perfect...let's get everything merged in and i'll fix the docs....let me know what to merge and in which order (prob doesn't matter)

testing on windows now

@jreback
Copy link
Contributor

jreback commented Jul 19, 2013

both PR passed on windows (amd-64)

@Komnomnomnom
Copy link
Contributor Author

Order shouldn't matter (I think) as they both touched different files. I re-based both onto master before pushing.

@Komnomnomnom
Copy link
Contributor Author

I'm happy for this to be merged now and if / when people are happy with #4299 that can be merged too.

@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

going (only this one until you tell me #4299) ready....in 3...2....1

@jreback jreback merged commit d8dc8ee into pandas-dev:master Jul 20, 2013
@Komnomnomnom
Copy link
Contributor Author

Cool, thanks

@Komnomnomnom Komnomnomnom deleted the ujson-precise-float branch July 20, 2013 00:58
@jreback
Copy link
Contributor

jreback commented Jul 20, 2013

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants