Skip to content

PERF: DataFrame.insert #42998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021
Merged

PERF: DataFrame.insert #42998

merged 3 commits into from
Aug 19, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry
from asv_bench.benchmarks.indexing import *

self = InsertColumns()
self.setup()

%timeit self.setup(); self.time_insert()
32.5 ms ± 382 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)   # <- master
20.7 ms ± 744 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)   # <- PR

%timeit self.setup(); self.time_insert_middle()
37.2 ms ± 407 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- master
25.1 ms ± 513 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- PR

@jreback jreback added Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Aug 12, 2021
@jreback jreback added this to the 1.4 milestone Aug 12, 2021
@jreback
Copy link
Contributor

jreback commented Aug 19, 2021

looks fine. can you rebase

@jreback jreback merged commit 01b0ad5 into pandas-dev:master Aug 19, 2021
@jbrockmendel jbrockmendel deleted the perf-insert branch August 19, 2021 21:00
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 29, 2021
4 tasks
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants