Skip to content

BUG GH#40498 Fillna other missing values not modified #42981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -6275,11 +6275,13 @@ def fillna(
else:
if self.ndim == 1:
if isinstance(value, (dict, ABCSeries)):
value = create_series_with_explicit_dtype(
value_map = create_series_with_explicit_dtype(
value, dtype_if_empty=object
)
value = value.reindex(self.index, copy=False)
value = value._values
value = self.copy()
modification_index = value.index.intersection(value_map.index)
if not modification_index.empty:
value.loc[modification_index] = value_map[modification_index]
elif not is_list_like(value):
pass
else:
Expand Down
42 changes: 42 additions & 0 deletions pandas/tests/frame/methods/test_fillna.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,48 @@ def test_fillna_tzaware_different_column(self):
)
tm.assert_frame_equal(result, expected)

def test_null_value_replacement(self):
# GH$40498
df = DataFrame(
{
"A": [1, 2, None, 4],
"B": [2, None, 6, 8],
}
)
value = np.nan
result = df.fillna(value)

expected = DataFrame(
{
"A": [1, 2, np.nan, 4],
"B": [2, np.nan, 6, 8],
}
)

tm.assert_frame_equal(result, expected)

def test_other_missing_values_not_modified(
self, unique_nulls_fixture, unique_nulls_fixture2
):
# GH#40498
df = DataFrame(
{
"A": [1, unique_nulls_fixture, unique_nulls_fixture2, "four"],
"B": [2, unique_nulls_fixture, unique_nulls_fixture2, "eight"],
}
)
value = {"A": {1: 0}, "B": {2: 0}}
result = df.fillna(value)

expected = DataFrame(
{
"A": [1, 0, unique_nulls_fixture2, "four"],
"B": [2, unique_nulls_fixture, 0, "eight"],
}
)

tm.assert_frame_equal(result, expected)

def test_na_actions_categorical(self):

cat = Categorical([1, 2, 3, np.nan], categories=[1, 2, 3])
Expand Down
24 changes: 24 additions & 0 deletions pandas/tests/series/methods/test_fillna.py
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,30 @@ def test_fillna_numeric_inplace(self):
expected = x.fillna(value=0)
tm.assert_series_equal(y, expected)

def test_fillna_null_value_replacement(self):
# GH#40498
ser = Series([None])

value = np.nan
result = ser.fillna(value)

expected = Series([np.nan])

tm.assert_series_equal(result, expected)

def test_fillna_other_missing_values_not_modified(
self, unique_nulls_fixture, unique_nulls_fixture2
):
# GH#40498
ser = Series([1, unique_nulls_fixture, unique_nulls_fixture2, "four"])

value = {2: 0}
result = ser.fillna(value)

expected = Series([1, unique_nulls_fixture, 0, "four"])

tm.assert_series_equal(result, expected)

# ---------------------------------------------------------------
# CategoricalDtype

Expand Down