Skip to content

DOC: updates documentations Closes #21749 #42979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2021

Conversation

salomondush
Copy link
Contributor

@salomondush salomondush commented Aug 11, 2021

@pep8speaks
Copy link

pep8speaks commented Aug 11, 2021

Hello @salomondush! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-16 18:33:32 UTC

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these should use the standard conventions (except for the internal uses of network)

@jreback jreback added the Docs label Aug 11, 2021
@jreback jreback added this to the 1.4 milestone Aug 16, 2021
@jreback
Copy link
Contributor

jreback commented Aug 16, 2021

great does this close all of the items in the original issue?

@salomondush
Copy link
Contributor Author

I only changed those in the directory ./pandas/util/testing.py. Others have remained the same.

@jreback jreback merged commit 73a69fd into pandas-dev:master Aug 17, 2021
@jreback
Copy link
Contributor

jreback commented Aug 17, 2021

thanks @salomondush happy to have a PR on other items in the original issue as well

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants