ENH: max_rows max_cols kw for Styler.to_html + styler.options
#42972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
jreback
added
Output-Formatting
# Conflicts: # pandas/tests/io/formats/style/test_html.py
attack68
changed the title
max_rows max_cols to Styler.to_htmlmax_rows max_cols to Styler.to_html
# Conflicts: # pandas/tests/io/formats/style/test_html.py
20 tasks
attack68
changed the title
max_rows max_cols to Styler.to_htmlmax_rows max_cols kw for Styler.to_html + styler.options
attack68
added
Enhancement
IO HTML
jreback
reviewed
Aug 31, 2021
| @@ -836,6 +871,11 @@ def scale_down(rn, cn): | |||
| else: | |||
| return int(rn * scaling_factor), cn | |||
|
|
|||
| if max_rows: | |||
There was a problem hiding this comment.
this exercised enough in tests?
There was a problem hiding this comment.
added specific cases
# Conflicts: # doc/source/user_guide/options.rst # doc/source/whatsnew/v1.4.0.rst # pandas/core/config_init.py # pandas/io/formats/style.py
|
can you merge master |
# Conflicts: # doc/source/whatsnew/v1.4.0.rst
jreback
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one more item towards deprecating
DataFrame.to_htmlfor #41693options.rstand an item towards consistent
pandas.optionsfor #41395