TST: GH34037 add test for type error when using parameter 'min_period' #42940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
horaceklai
commented
Aug 8, 2021
•
horaceklai
commented
- closes BUG: "min_period" and "min_periods" problem in df.groupby().rolling #34037
- [ x] tests added / passed
- [x ] Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Aug 8, 2021
pandas/tests/groupby/test_groupby.py
Outdated
| @@ -2407,3 +2407,19 @@ def test_datetime_categorical_multikey_groupby_indices(): | |||
| ("c", Timestamp("2018-03-01 00:00:00")): np.array([2]), | |||
| } | |||
| assert result == expected | |||
|
|
|||
|
|
|||
| def test_rolling_min_period(): | |||
There was a problem hiding this comment.
Good to mention in this function title that min_period is incorrect
mroeschke
reviewed
Aug 8, 2021
pandas/tests/groupby/test_groupby.py
Outdated
| test_df.columns = ["name", "val"] | ||
|
|
||
| # correct one | ||
| test_df.groupby("name")["val"].rolling(window=2, min_periods=1).sum() |
mroeschke
reviewed
Aug 8, 2021
pandas/tests/groupby/test_groupby.py
Outdated
| # GH34037 | ||
| result_error_msg = r"__init__\(\) got an unexpected keyword argument 'min_period'" | ||
| with pytest.raises(TypeError, match=result_error_msg): | ||
| name_l = ["Alice"] * 5 + ["Bob"] * 5 |
There was a problem hiding this comment.
All the setup code should ideally be before the pytest.raises call
mroeschke
added
Testing
horaceklai
force-pushed
the
test-min_period
branch
from
98ca0d9 to
5c61723
Compare
mroeschke
approved these changes
Aug 8, 2021
|
Thanks @horaceklai |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.