TST: add test for getting array from series #42939

horaceklai · 2021-08-08T21:00:00Z

closes np.array([pd.Series({'a':'a'})]) works but np.array([pd.Series({1:1})]) doesn't #38543
[ x] tests added / passed
[x ] Ensure all linting tests pass, see here for how to run them
whatsnew entry

jreback · 2021-08-08T23:21:21Z

pandas/tests/arrays/test_array.py

@@ -182,6 +182,13 @@ def test_array_copy():
    assert np.shares_memory(a, b._ndarray) is True


+def test_array_from_series():


can you instead put in pandas/tests/test_constructors.py

and can you assert the results of each of these with tm.assert_numpy_array_equal.

mroeschke · 2021-08-08T23:21:48Z

pandas/tests/arrays/test_array.py

@@ -182,6 +182,13 @@ def test_array_copy():
    assert np.shares_memory(a, b._ndarray) is True


+def test_array_from_series():
+    # GH38543
+    np.array([pd.Series({0: 0})])


Could you use pytest.mark.parameterize to test each case?

Additionally, these tests should follow the format

result = np.array(np.array([pd.Series({0: 0})])) expected = np.array(...) # another way to construct the result tm.assert_numpy_array_equal(result, expected)

mroeschke · 2021-08-17T00:22:05Z

Mind investigating the failures @horaceklai?

horaceklai · 2021-08-17T21:28:10Z

Mind investigating the failures @horaceklai?

Do you mean investigating the bug that the issue initially described?

The failure has to do with the bug reoccurring. I thought it was fixed from the comments written before I took this issue, but it is here now.

jreback · 2021-08-19T01:41:11Z

pandas/tests/test_constructors.py

@@ -0,0 +1,18 @@
+import numpy as np


sorry menat pandas/tests/series/test_constructors.py

jreback · 2021-08-31T23:44:27Z

can you merge master and ping on green.

…_array

lithomas1

You need to skip this test on old numpy. I believe 1.19 is the first version it works on but haven't checked.

horaceklai · 2021-09-05T12:48:54Z

You need to skip this test on old numpy. I believe 1.19 is the first version it works on but haven't checked.

Hi Thomas,

I am not sure how to skip certain tests for old numpy. Mind giving me a tip?

Thanks,
Horace

lithomas1 · 2021-09-05T14:55:07Z

Have a look at the pytest.mark.skipif decorator(https://docs.pytest.org/en/latest/reference/reference.html#pytest-mark-skipif-ref).

You'll also need

pandas/pandas/compat/numpy/__init__.py

Line 12 in 35d52ff

np_version_under1p19 = _nlv < Version("1.19")

from pandas.compat.numpy.
This variable is a boolean that tells you if the numpy version is under 1.19

So you'll have something like

from pandas.compat.numpy import np_version_under1p19
...
...
...
@pytest.mark.skipif(np_version_under1p19, reason="fails on numpy below 1.19")
[your test code]

Let me know if you have more questions.

horaceklai · 2021-09-06T12:34:21Z

Have a look at the pytest.mark.skipif decorator(https://docs.pytest.org/en/latest/reference/reference.html#pytest-mark-skipif-ref).

You'll also need

pandas/pandas/compat/numpy/__init__.py

Line 12 in 35d52ff

np_version_under1p19 = _nlv < Version("1.19")

from pandas.compat.numpy.
This variable is a boolean that tells you if the numpy version is under 1.19
So you'll have something like
from pandas.compat.numpy import np_version_under1p19
...
...
...
@pytest.mark.skipif(np_version_under1p19, reason="fails on numpy below 1.19")
[your test code]
Let me know if you have more questions.

Thanks! You pretty much did all the work for me and I learned something new!

jreback · 2021-09-06T15:25:43Z

pandas/tests/series/test_constructors.py

+        ({1: 1}, np.array([[1]], dtype=np.int64)),
+    ],
+)
+@pytest.mark.skipif(np_version_under1p19, reason="fails on numpy below 1.19")


can you write a tests that specifically tests < numpy 1.19. e.g. an asserts the error that happens (OT I wonder if this is fixable on the pandas side).

horaceklai · 2021-09-06T15:32:44Z

Yes, good idea.

…

On Mon, Sep 6, 2021, 5:25 PM Jeff Reback ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/tests/series/test_constructors.py <#42939 (comment)>: > @@ -1840,3 +1841,17 @@ def test_constructor(rand_series_with_duplicate_datetimeindex): dups = rand_series_with_duplicate_datetimeindex assert isinstance(dups, Series) assert isinstance(dups.index, DatetimeIndex) + + ***@***.***( + "input_dict,expected", + [ + ({0: 0}, np.array([[0]], dtype=np.int64)), + ({"a": "a"}, np.array([["a"]], dtype=object)), + ({1: 1}, np.array([[1]], dtype=np.int64)), + ], +) ***@***.***(np_version_under1p19, reason="fails on numpy below 1.19") can you write a tests that specifically tests < numpy 1.19. e.g. an asserts the error that happens (OT I wonder if this is fixable on the pandas side). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42939 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKTQNIYUAY6N3G6P42VDOQTUATMQHANCNFSM5BY3FVMA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

lithomas1 · 2021-09-12T18:14:58Z

@horaceklai Can you fix the test failures?

horaceklai · 2021-09-12T21:07:58Z

@horaceklai Can you fix the test failures?

I think I fixed it now with the error message not matching, but now I'm having another error that I don't know if it is related. The test is taking too much time (> 1hr)

lithomas1

Lgtm. Thanks for the PR. Don't worry about the timeouts.

mroeschke · 2021-09-13T02:18:33Z

Thanks @horaceklai

* TST: add test for getting array from series * TST: add test for getting array from series * add skipif for low versions of numpy * add dtype np.int64 * add test to check that exception is raised for np version < 1.19 * change matched string to '0'

jreback added this to the 1.4 milestone Aug 8, 2021

jreback added Constructors Series/DataFrame/Index/pd.array Constructors Testing pandas testing functions or related to the test suite Upstream issue Issue related to pandas dependency labels Aug 8, 2021

jreback requested changes Aug 8, 2021

View reviewed changes

mroeschke reviewed Aug 8, 2021

View reviewed changes

horaceklai force-pushed the test-series_to_np_array branch from 3a606ad to 0b32f59 Compare August 9, 2021 22:01

horaceklai mentioned this pull request Aug 10, 2021

np.array([pd.Series({'a':'a'})]) works but np.array([pd.Series({1:1})]) doesn't #38543

Closed

TST: add test for getting array from series

777864d

horaceklai force-pushed the test-series_to_np_array branch from 0b32f59 to 777864d Compare August 11, 2021 20:59

horaceklai requested review from mroeschke and jreback August 12, 2021 19:55

jreback requested changes Aug 19, 2021

View reviewed changes

TST: add test for getting array from series

a74d8a0

horaceklai requested a review from jreback August 22, 2021 08:48

Merge remote-tracking branch 'upstream/master' into test-series_to_np…

9291d2a

…_array

lithomas1 requested changes Sep 5, 2021

View reviewed changes

horaceklai added 2 commits September 5, 2021 20:53

add skipif for low versions of numpy

f4c4f3b

add dtype np.int64

3e70ff1

horaceklai requested a review from lithomas1 September 6, 2021 12:34

jreback reviewed Sep 6, 2021

View reviewed changes

add test to check that exception is raised for np version < 1.19

89f6dd7

change matched string to '0'

5d620d3

horaceklai requested a review from jreback September 12, 2021 21:06

lithomas1 approved these changes Sep 13, 2021

View reviewed changes

mroeschke approved these changes Sep 13, 2021

View reviewed changes

mroeschke merged commit a54aa39 into pandas-dev:master Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: add test for getting array from series #42939

TST: add test for getting array from series #42939

horaceklai commented Aug 8, 2021 •

edited by mroeschke

Loading

jreback Aug 8, 2021

mroeschke Aug 8, 2021

mroeschke commented Aug 17, 2021

horaceklai commented Aug 17, 2021

jreback Aug 19, 2021

jreback commented Aug 31, 2021

lithomas1 left a comment

horaceklai commented Sep 5, 2021

lithomas1 commented Sep 5, 2021

horaceklai commented Sep 6, 2021

jreback Sep 6, 2021

horaceklai commented Sep 6, 2021 via email

lithomas1 commented Sep 12, 2021

horaceklai commented Sep 12, 2021

lithomas1 left a comment

mroeschke commented Sep 13, 2021

		@@ -182,6 +182,13 @@ def test_array_copy():
		assert np.shares_memory(a, b._ndarray) is True


		def test_array_from_series():

TST: add test for getting array from series #42939

TST: add test for getting array from series #42939

Conversation

horaceklai commented Aug 8, 2021 • edited by mroeschke Loading

jreback Aug 8, 2021

Choose a reason for hiding this comment

mroeschke Aug 8, 2021

Choose a reason for hiding this comment

mroeschke commented Aug 17, 2021

horaceklai commented Aug 17, 2021

jreback Aug 19, 2021

Choose a reason for hiding this comment

jreback commented Aug 31, 2021

lithomas1 left a comment

Choose a reason for hiding this comment

horaceklai commented Sep 5, 2021

lithomas1 commented Sep 5, 2021

horaceklai commented Sep 6, 2021

jreback Sep 6, 2021

Choose a reason for hiding this comment

horaceklai commented Sep 6, 2021 via email

lithomas1 commented Sep 12, 2021

horaceklai commented Sep 12, 2021

lithomas1 left a comment

Choose a reason for hiding this comment

mroeschke commented Sep 13, 2021

horaceklai commented Aug 8, 2021 •

edited by mroeschke

Loading