Skip to content

STYLE: pre-commit check on get/set_option usage #42924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

debnathshoham
Copy link
Member

This is failing across multiple locations. Is there a specific location where get/set_option can be used? or across everything?

@debnathshoham debnathshoham changed the title Gh38813 STYLE: pre-commit check on get/set_option usage Aug 7, 2021
@mzeitlin11
Copy link
Member

This is failing across multiple locations. Is there a specific location where get/set_option can be used? or across everything?

I think the idea is to replace with the context manager everywhere that get/set_option is not the system under test. Maybe best to start with a precursor PR changing all the places you find where it makes sense to do this replacement. Then in the PR adding the precommit check, can discuss which files it makes sense to skip for this check.

@mzeitlin11 mzeitlin11 added the Code Style Code style, linting, code_checks label Aug 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 7, 2021
@debnathshoham debnathshoham deleted the gh38813 branch September 7, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STYLE: use option_context almost always
2 participants