Skip to content

STYLE: moving unwanted pattern check to precommit #42923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 7, 2021
Merged

STYLE: moving unwanted pattern check to precommit #42923

merged 7 commits into from
Aug 7, 2021

Conversation

debnathshoham
Copy link
Member

@MarcoGorelli
Copy link
Member

cool, thanks - can you remove "patterns" from ci/code_checks as well? (e.g. in line 20)

@debnathshoham
Copy link
Member Author

@MarcoGorelli done.
Please let me know if this looks okay.

MarcoGorelli
MarcoGorelli approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks (minor point - the dots (.) in the entry, files, and exclude could be escaped (\.) as they all just check regular expressions, but this is fine as-in)

MarcoGorelli
MarcoGorelli suggested changes Aug 7, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's

pandas/.github/workflows/ci.yml

Lines 35 to 37 in eaee348

- name: Looking for unwanted patterns
run: ci/code_checks.sh patterns
if: always()

too

MarcoGorelli
MarcoGorelli approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mroeschke mroeschke added this to the 1.4 milestone Aug 7, 2021
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Aug 7, 2021
@mroeschke mroeschke merged commit 2af4ac0 into pandas-dev:master Aug 7, 2021
@mroeschke
Copy link
Member

Thanks @debnathshoham

@debnathshoham debnathshoham deleted the gh42123 branch August 8, 2021 05:40
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@debnathshoham @feefladder
STYLE: moving unwanted pattern check to precommit (pandas-dev#42923)
1f14660 
* STYLE: moving unwanted pattern check to precommit

* backtick check on new hook

* removed tick check from unwanted

* np.random.seed check in asv

* added to precommit; removed from code_check.sh

* removed patterns entirely from code_check.sh

* removed from ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

STYLE move patterns checks to pre-commit
3 participants
@debnathshoham @MarcoGorelli @mroeschke