Skip to content

TST: DataFrame initialization with an empty DataFrame with dtype #42890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

gcaria
Copy link
Contributor

@gcaria gcaria commented Aug 4, 2021

@jreback jreback added the Constructors Series/DataFrame/Index/pd.array Constructors label Aug 4, 2021
@jreback jreback added this to the 1.4 milestone Aug 4, 2021
@jreback jreback added the Testing pandas testing functions or related to the test suite label Aug 4, 2021
@pep8speaks
Copy link

pep8speaks commented Aug 4, 2021

Hello @gcaria! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-23 13:49:31 UTC

@gcaria
Copy link
Contributor Author

gcaria commented Aug 5, 2021

Thanks for the help @jreback.

However, it seems that pandas classes get capitalized in the test names (at least in this file), see the test just above (test_constructor_DataFrame) and the various test_constructor_Series_....

@alimcmaster1
Copy link
Member

Thanks for the help @jreback.

However, it seems that pandas classes get capitalized in the test names (at least in this file), see the test just above (test_constructor_DataFrame) and the various test_constructor_Series_....

Thanks for the PR - should be lower case as Jeff suggest and per PEP8. Can you double check why CI is failing/merge master? This looks good to me otherwise :)

@gcaria
Copy link
Contributor Author

gcaria commented Aug 23, 2021

Thanks @alimcmaster1.Rebased to master and now all tests have passed

@jreback jreback merged commit 5d01add into pandas-dev:master Aug 31, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

thanks @gcaria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame initialization with an empty DataFrame with dtype
4 participants