BUG: dataframe.rolling along rows drops float16 #42884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debnathshoham
commented
Aug 4, 2021
debnathshoham
commented
- closes BUG: DataFrame.rolling(axis=1) operations drop/ignore float16 and float32 columns #41779
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Window
jreback
requested changes
Aug 4, 2021
pandas/tests/window/test_rolling.py
Outdated
| @@ -1432,3 +1432,30 @@ def test_rolling_float_dtype(float_dtype): | |||
| expected = DataFrame({"A": [np.nan] * 5, "B": range(10, 20, 2)}, dtype=float_dtype) | |||
| result = df.rolling(2, axis=1).sum() | |||
| tm.assert_frame_equal(result, expected, check_dtype=False) | |||
|
|
|||
|
|
|||
| def test_rolling_rows(): | |||
There was a problem hiding this comment.
-> test_rolling_numeric_dtypes
| # GH#41779 | ||
| df = DataFrame(np.arange(24).reshape(4, 6), columns=list("abcdef")).astype( | ||
| { | ||
| "a": "float16", |
There was a problem hiding this comment.
can you add the uint dtypes as well
|
thanks @debnathshoham failures unrelated |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.