-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: Series.nlargest with masked arrays #42838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
0c1ab8f
183dacc
8a62160
7340098
6c64ba0
1975cb2
8180d39
03dea8d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
Literal, | ||
Union, | ||
cast, | ||
final, | ||
) | ||
from warnings import warn | ||
|
||
|
@@ -1211,12 +1212,15 @@ def __init__(self, obj, n: int, keep: str): | |
def compute(self, method: str) -> DataFrame | Series: | ||
raise NotImplementedError | ||
|
||
@final | ||
def nlargest(self): | ||
return self.compute("nlargest") | ||
|
||
@final | ||
def nsmallest(self): | ||
return self.compute("nsmallest") | ||
|
||
@final | ||
@staticmethod | ||
def is_valid_dtype_n_method(dtype: DtypeObj) -> bool: | ||
""" | ||
|
@@ -1255,6 +1259,18 @@ def compute(self, method: str) -> Series: | |
|
||
dropped = self.obj.dropna() | ||
|
||
if is_extension_array_dtype(dropped.dtype): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this prefereable to hanlding on L1281 with the other dtypes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bc ensure_data does the wrong thing with MaskedArrays, np.asarray(obj) defaults to object dtype. we could kludge _ensure_data to work in cases where we dont have any pd.NAs, but doing it here lets us handle cases with NAs too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
this is very unfortunate. I don't really like this approach here. i suppose its ok for a backport though this is na experimental type and so i don't consider this regression to be a big deal. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the more i work on it, the more i want to nuke NA from space There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok what is involved with changing this to a non-recursive formulation though? e.g. ensure_data should be able to handle NA (if not we will have other issues) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Three options:
I decided the approach here was less kludgy than those in part bc this function uses There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is 1 a kludge? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bc its special-casing for MaskedArray and special casing for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. worse than that, it isnt |
||
# GH#41816 bc we have dropped NAs above, MaskedArrays can use the | ||
# numpy logic. | ||
from pandas.core.arrays import BaseMaskedArray | ||
|
||
arr = dropped._values | ||
if isinstance(arr, BaseMaskedArray): | ||
ser = type(dropped)(arr._data, index=dropped.index, name=dropped.name) | ||
|
||
result = type(self)(ser, n=self.n, keep=self.keep).compute(method) | ||
return result.astype(arr.dtype) | ||
|
||
# slow method | ||
if n >= len(self.obj): | ||
ascending = method == "nsmallest" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to change to #42816. will do that after backport is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in #42983