BUG: Fix dtypes for read_json #42819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
r-raymond
commented
Jul 30, 2021
•
r-raymond
commented
- closes read_json ignores dictionary as dtype #33205
- closes pd.read_json ignores 'category' dtypes #21892
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
r-raymond
force-pushed
the
fix/read_json-dtypes
branch
from
06c9061 to
1e75718
Compare
mzeitlin11
reviewed
Jul 31, 2021
There was a problem hiding this comment.
Thanks for the pr @r-raymond! Small comments, plus if you could please add a whatsnew note about this change targeting 1.4
mzeitlin11
added
Bug
Dtype Conversions
Co-authored-by: Matthew Zeitlin <[email protected]>
|
Ready to be merged from my side. |
jreback
approved these changes
Aug 5, 2021
|
Seems like the tests are flaky, can we rerun them? |
|
there is a failure on master, will merge when fixed |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@jreback greenish if still good to merge |
|
can you merge master and ping on green |
|
ping @jreback Thanks for keeping the ball rolling on this! |
|
Thanks @r-raymond very nice! |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
* Fix dtypes for read_json * Address comments * Add whatsnew entry * Update doc/source/whatsnew/v1.4.0.rst Co-authored-by: Matthew Zeitlin <[email protected]> * Linting Co-authored-by: Matthew Zeitlin <[email protected]>
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Oct 10, 2021
* Fix dtypes for read_json * Address comments * Add whatsnew entry * Update doc/source/whatsnew/v1.4.0.rst Co-authored-by: Matthew Zeitlin <[email protected]> * Linting Co-authored-by: Matthew Zeitlin <[email protected]>
3 tasks
rs2
pushed a commit
to rs2/pandas
that referenced
this pull request
Nov 6, 2023
* Fix dtypes for read_json * Address comments * Add whatsnew entry * Update doc/source/whatsnew/v1.4.0.rst Co-authored-by: Matthew Zeitlin <[email protected]> * Linting Co-authored-by: Matthew Zeitlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.