DataFrame.drop silently does nothing if MultiIndex has duplicates #42801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Jul 29, 2021
phofl
commented
- closes BUG: DataFrame.drop() can't drop row by index tuple when MultiIndex has duplicated value in a level. #42771
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
phofl
added
MultiIndex
Regression
|
lgtm. @jbrockmendel ok here? |
| isinstance(axis, MultiIndex) | ||
| and labels.dtype == "object" | ||
| and not is_tuple_labels | ||
| ): |
There was a problem hiding this comment.
can you add a comment below this pointing back to the PR/issue
|
thanks @phofl |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 31, 2021
… MultiIndex has duplicates
|
Something went wrong ... Please have a look at my logs. |
phofl
added a commit
that referenced
this pull request
Jul 31, 2021
…x has duplicates (#42829) Co-authored-by: Patrick Hoefler <[email protected]>
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.