BUG: enable test_numpy tests with ArrayManager #42780
Conversation
jbrockmendel
commented
Jul 28, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -697,6 +699,7 @@ def __init__( | |||
|
|
|||
| if verify_integrity: | |||
| self._axes = [ensure_index(ax) for ax in axes] | |||
| arrays = [extract_pandas_array(x, None, 1)[0] for x in arrays] | |||
There was a problem hiding this comment.
Slightly off topic (since we already do this elsewhere), but this check is only needed for when using the patched version in the tests?
If so, I am wondering if we should use some "TEST_MODE" env variable so we can check that here and do this step only when running the patched test, to avoid the overhead this is adding for real code.
There was a problem hiding this comment.
yah i increasingly think that test file is more trouble than its worth. we should try to salvage the subset of tests that directly test PandasArray and disable the others
| @skip_nested | ||
| def test_setitem_loc_scalar_mixed(self, data): | ||
| # AssertionError | ||
| super().test_setitem_loc_scalar_mixed(data) |
There was a problem hiding this comment.
Where those already working? (as those are generally skipped, not only for ArrayManager)
There was a problem hiding this comment.
AFAICT the added check in indexing.py fixed this for both AM and BM.
There was a problem hiding this comment.
do we need a note for this? e.g. is this a user facing bug fix?
