BUG: Incorrect variable window bounds for first row when offset cover all rows #42776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dicristina! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-06 16:42:02 UTC |
There were some CI issues. Hopefully this will fix them.
This resolves a conflict in whatsnew 1.3.2.
jreback
requested changes
Aug 5, 2021
|
cc @mroeschke |
|
@dicristina can you merge master |
mroeschke
reviewed
Aug 6, 2021
mroeschke
reviewed
Aug 6, 2021
mroeschke
approved these changes
Aug 6, 2021
jreback
approved these changes
Aug 7, 2021
|
thanks @dicristina |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 7, 2021
…or first row when offset cover all rows
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Aug 8, 2021
…ow when offset cover all rows (#42929) Co-authored-by: dicristina <[email protected]>
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for cases in which the end bound of the variable window for the first row extends past the last row, that is, cases in which the offset is large enough to cover all the rows.