-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Series.groupby fails with InvalidIndexError on time series with … #42772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @suoniq! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-09-05 02:10:58 UTC |
…a tuple-named grouper. (#42731)
Please note that I'll be on vacation until mid-August and plan to not come close to any computers. So I won't respond Do any necessary changes to the MR if you don't want to wait. See you then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a whatsnew note for 1.4, grouping section in bug fixes
cc @rhshadrach if you can look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good - but I don't think the test is as intended.
@suoniq - friendly ping. It'd be great to get this in for 1.3.2 and I think it's almost there. If you don't have time to finish it up, would you mind if I pushed it across the finish line? |
…731-groupby-fails-with-InvalidIndexError
@simonjayhawkins - I've tagged this as 1.3.2 but certainly don't hold up the release if it doesn't get in by tomorrow. @suoniq - Thanks for the PR and apologies for the ping above, I missed your note about being out. |
moving to 1.3.3 |
Hi, back from vacation. |
@suoniq I didn't think the intention was to test on empty objects, but let me know if this is incorrect. I think we're in good shape here, just waiting on review. More than happy if you want to take the reins back again! |
@jreback and @jbrockmendel for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, pls merge master and ping on green
…731-groupby-fails-with-InvalidIndexError
Thanks @jreback - comment addressed and green. |
thanks @suoniq and @rhshadrach |
…ndexError on time series with …
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
…on time series with … (#43425) Co-authored-by: suoniq <[email protected]>
…a tuple-named grouper. (#42731)
Skipped any "What's New" for now, since it's not decided which version will have it. Will update as soon as this is decided.