Skip to content

BUG: Series.groupby fails with InvalidIndexError on time series with … #42772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from Sep 6, 2021
Merged

BUG: Series.groupby fails with InvalidIndexError on time series with … #42772

merged 5 commits into from Sep 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2021

…a tuple-named grouper. (#42731)

Skipped any "What's New" for now, since it's not decided which version will have it. Will update as soon as this is decided.

@pep8speaks
Copy link

pep8speaks commented Jul 28, 2021

Hello @suoniq! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-05 02:10:58 UTC

@ghost
Copy link
Author

ghost commented Jul 31, 2021

Please note that I'll be on vacation until mid-August and plan to not come close to any computers. So I won't respond Do any necessary changes to the MR if you don't want to wait. See you then.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note for 1.4, grouping section in bug fixes

@jreback
Copy link
Contributor

jreback commented Aug 6, 2021

cc @rhshadrach if you can look

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good - but I don't think the test is as intended.

@rhshadrach
Copy link
Member

@suoniq - friendly ping. It'd be great to get this in for 1.3.2 and I think it's almost there. If you don't have time to finish it up, would you mind if I pushed it across the finish line?

@rhshadrach rhshadrach added Regression Functionality that used to work in a prior pandas version Indexing Related to indexing on series/frames, not to indexes themselves labels Aug 14, 2021
@rhshadrach rhshadrach added this to the 1.3.2 milestone Aug 14, 2021
@rhshadrach
Copy link
Member

@simonjayhawkins - I've tagged this as 1.3.2 but certainly don't hold up the release if it doesn't get in by tomorrow.

@suoniq - Thanks for the PR and apologies for the ping above, I missed your note about being out.

cc @jreback @jbrockmendel

@simonjayhawkins
Copy link
Member

moving to 1.3.3

@simonjayhawkins simonjayhawkins modified the milestones: 1.3.2, 1.3.3 Aug 15, 2021
@ghost
Copy link
Author

ghost commented Aug 18, 2021

Hi, back from vacation.
@rhshadrach Of course I am fine with you taking over. Still consider the original test as good b/c it pin-pointed exactly the problem: time series behave differently than series indexed differently. Was red before the fix as well. (-;
Anyway, please let me know, if there is anything left I can do.

@rhshadrach
Copy link
Member

@suoniq I didn't think the intention was to test on empty objects, but let me know if this is incorrect. I think we're in good shape here, just waiting on review. More than happy if you want to take the reins back again!

@rhshadrach
Copy link
Member

@jreback and @jbrockmendel for review

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, pls merge master and ping on green

@rhshadrach
Copy link
Member

Thanks @jreback - comment addressed and green.

@jreback jreback merged commit 283956e into pandas-dev:master Sep 6, 2021
@jreback
Copy link
Contributor

jreback commented Sep 6, 2021

thanks @suoniq and @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 6, 2021
@jreback
Copy link
Contributor

jreback commented Sep 6, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 6, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.groupby fails with InvalidIndexError on time series with a tuple-named grouper.
5 participants