TST: test_column_types_consistent #42725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
jreback
requested changes
Jul 26, 2021
There was a problem hiding this comment.
precommit is failing: https://github.com/pandas-dev/pandas/pull/42725/checks?check_run_id=3162612999
make sure you do these locally before commit
pandas/tests/generic/test_frame.py
Outdated
| @@ -87,6 +88,37 @@ def test_metadata_propagation_indiv_resample(self): | |||
| result = df.resample("1T") | |||
| self.check_metadata(df, result) | |||
|
|
|||
| def test_column_types_consistent(self): | |||
There was a problem hiding this comment.
can you move to tests/frame/indexing/test_loc.py
phofl
reviewed
Jul 26, 2021
pandas/tests/generic/test_frame.py
Outdated
| "A": ["String 1", np.NaN, "String 2"], | ||
| "B": [ | ||
| Timestamp("2019-06-11 11:00:00"), | ||
| np.NaN, |
phofl
approved these changes
Jul 27, 2021
jreback
approved these changes
Jul 28, 2021
|
thanks @shiv-io |
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the following issue: #26779