Skip to content

TST: Fixed doctest in Styler.to_latex #42672 #42718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

TST: Fixed doctest in Styler.to_latex #42672 #42718

merged 1 commit into from
Jul 28, 2021

Conversation

willie3838
Copy link
Contributor

@willie3838 willie3838 commented Jul 25, 2021 •
edited
Loading

@willie3838
Copy link
Contributor Author

I'm new to contributing to open source and I was wondering how I would go about fixing the failed checks

@phofl
Copy link
Member

phofl commented Jul 26, 2021

New failures are not related to your changes, they were caused by a xarray upgrade see #42716

phofl
phofl approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @attack68

@simonjayhawkins simonjayhawkins added Docs Testing pandas testing functions or related to the test suite labels Jul 26, 2021
@jreback jreback added this to the 1.3.2 milestone Jul 26, 2021
@jreback
Copy link
Contributor

jreback commented Jul 26, 2021

hmm do we need to backport this?

attack68
attack68 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i recommended skipping this doc test.

don't think these need to be backported - we can make sure that ../formats/style.py is switched on for doctesting only in 1.4.0.

@simonjayhawkins simonjayhawkins modified the milestones: 1.3.2, 1.4 Jul 27, 2021
@jbrockmendel
Copy link
Member

looks fine, gets us back to (or closer to) a green CI i think

@jreback jreback added the Styler conditional formatting using DataFrame.style label Jul 28, 2021
@jreback jreback merged commit 875b224 into pandas-dev:master Jul 28, 2021
@jreback
Copy link
Contributor

jreback commented Jul 28, 2021

thanks @willie3838

CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
@willie3838 @CGe0516
skipped doc test (pandas-dev#42718)
adb7664
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@willie3838 @feefladder
skipped doc test (pandas-dev#42718)
280dd4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attack68 attack68 attack68 approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Docs Styler conditional formatting using DataFrame.style Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

TST: Fix doctest in Styler.to_latex
6 participants
@willie3838 @phofl @jreback @jbrockmendel @attack68 @simonjayhawkins