Revert "Regression in merge_asof raising KeyError when at least one by column is in index #42691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y column is in index" This reverts commit bc2e8ca
|
I did something similar about 6 months ago. No worries. We reverted that. |
|
Thanks for the quick help, merging this then Comforting, that I am not the only one this happened to |
|
yep no problemo! |
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
…y column is in index" (pandas-dev#42691) This reverts commit bc2e8ca
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…y column is in index" (pandas-dev#42691) This reverts commit bc2e8ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am really sorry for this.
I messed up my acces token and accidentially pushed to master. Not sure how this could happen :(
If someone has a better idea than simply reverting we can close this
cc @pandas-dev/pandas-core