ENH: Add BytesIOWrapper #42669
Merged
ENH: Add BytesIOWrapper #42669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Jul 23, 2021
twoertwein
reviewed
Jul 23, 2021
twoertwein
reviewed
Jul 24, 2021
twoertwein
reviewed
Jul 26, 2021
jreback
added
Enhancement
IO Data
twoertwein
approved these changes
Jul 28, 2021
| @@ -878,6 +888,46 @@ def __next__(self) -> str: | |||
| return newline.lstrip("\n") | |||
|
|
|||
|
|
|||
| # Wrapper that wraps a StringIO buffer and reads bytes from it | |||
| # Created for compat with pyarrow read_csv | |||
| class BytesIOWrapper(io.BytesIO): | |||
There was a problem hiding this comment.
I don't know what pandas's policy is on public/private classes. Maybe name the class _BytesIOWrapper. @jreback
There was a problem hiding this comment.
this is fine, this entire module is de-facto private.
There was a problem hiding this comment.
and we already expose TextIOWrapper so this is similar
|
gentle ping @jreback @jorisvandenbossche this is blocking integration of the pyarrow csv reader. |
jreback
approved these changes
Aug 4, 2021
| @@ -878,6 +888,46 @@ def __next__(self) -> str: | |||
| return newline.lstrip("\n") | |||
|
|
|||
|
|
|||
| # Wrapper that wraps a StringIO buffer and reads bytes from it | |||
| # Created for compat with pyarrow read_csv | |||
| class BytesIOWrapper(io.BytesIO): | |||
There was a problem hiding this comment.
this is fine, this entire module is de-facto private.
| @@ -878,6 +888,46 @@ def __next__(self) -> str: | |||
| return newline.lstrip("\n") | |||
|
|
|||
|
|
|||
| # Wrapper that wraps a StringIO buffer and reads bytes from it | |||
| # Created for compat with pyarrow read_csv | |||
| class BytesIOWrapper(io.BytesIO): | |||
There was a problem hiding this comment.
and we already expose TextIOWrapper so this is similar
|
thanks @lithomas1 very nice! and thanks @twoertwein for reviewing |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor for pyarrow csv reader integration.
@jorisvandenbossche Do you know if there is any workaround I can use to read StringIO's on the arrow side? Adding this wrapper feels very hacky.