Skip to content

Backport PR #42261 (BUG: Fix to_datetime() cache behaviour to not omit duplicated output values) #42660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2021
Merged

Backport PR #42261 (BUG: Fix to_datetime() cache behaviour to not omit duplicated output values) #42660

merged 1 commit into from
Jul 22, 2021

Conversation

simonjayhawkins
Copy link
Member

Backport PR #42261

@simonjayhawkins simonjayhawkins added the Datetime Datetime data dtype label Jul 22, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3.1 milestone Jul 22, 2021
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 22, 2021
Merged
@simonjayhawkins simonjayhawkins requested a review from phofl July 22, 2021 13:41
@simonjayhawkins
Copy link
Member Author

@phofl can ignore the test_rename_inplace failure.

Does this fix seem reasonable and OK to backport.

phofl
phofl reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself looks good, the test is somewhat difficult to read imo, but should not influence the backport I think

@simonjayhawkins
Copy link
Member Author

Thanks @phofl

@simonjayhawkins simonjayhawkins merged commit 1781d5a into pandas-dev:1.3.x Jul 22, 2021
@simonjayhawkins simonjayhawkins deleted the backport-of-42261 branch July 22, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @phofl @zyc09