BUG: misleading error creating df from 2d array #42646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debnathshoham
commented
Jul 21, 2021
•
debnathshoham
commented
- closes BUG: Constructing a df using 2D numpy arrays raises misleading error #42463
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -615,6 +615,8 @@ def _extract_index(data) -> Index: | |||
| elif is_list_like(val) and getattr(val, "ndim", 1) == 1: | |||
| have_raw_arrays = True | |||
| raw_lengths.append(len(val)) | |||
| elif isinstance(val, np.ndarray) and getattr(val, "ndim", 1) > 1: | |||
There was a problem hiding this comment.
after the isinstance check the getattr can check can just be val.ndim > 1
|
|
| @@ -615,6 +615,8 @@ def _extract_index(data) -> Index: | |||
| elif is_list_like(val) and getattr(val, "ndim", 1) == 1: | |||
| have_raw_arrays = True | |||
| raw_lengths.append(len(val)) | |||
| elif isinstance(val, np.ndarray) and val.ndim > 1: | |||
| raise ValueError("Data must be 1-dimensional") | |||
There was a problem hiding this comment.
maybe something like "Per-column arrays must each be 1-dimensional"?
| ], | ||
| ) | ||
| def test_error_from_2darray(self, col_a, col_b): | ||
| msg = "Data must be 1-dimensional" |
There was a problem hiding this comment.
probably need to update the message here?
There was a problem hiding this comment.
My bad. Updated the msg in test.
jreback
added
Error Reporting
|
@debnathshoham lgtm. can you add a whatsnew note (bug fixes for reshaping for 1.4 is good), a short note about the revised error that a user would see. ping on green. |
|
@jreback Green-ish (unrelated failures) |
|
thanks @debnathshoham |
sthagen
added a commit
to sthagen/pandas-dev-pandas
that referenced
this pull request
Jul 28, 2021
BUG: misleading error creating df from 2d array (pandas-dev#42646)
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.