BUG: KeyError when a series popped from data frame with bool indexer #42644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
requested changes
Jul 24, 2021
jreback
requested changes
Jul 25, 2021
pandas/core/series.py
Outdated
| @@ -1234,7 +1234,7 @@ def _maybe_update_cacher( | |||
| if ref is None: | |||
| del self._cacher | |||
| else: | |||
| if len(self) == len(ref): | |||
| if len(self) == len(ref) and self.name in ref.columns: # GH#42530 | |||
There was a problem hiding this comment.
don't put the comment after the line, makes this very hard to read. you can add in the if block with an explanation.
would be ok making this an if/elif/else block
jreback
added
Bug
Indexing
phofl
approved these changes
Jul 25, 2021
jreback
approved these changes
Jul 26, 2021
|
thanks @debnathshoham |
3 tasks
|
@meeseeksdev backport 1.3.x |
This comment has been minimized.
This comment has been minimized.
|
@simonjayhawkins you are right, the release note is in the wrong place. |
|
just doing the backport now with the release note in 1.3.2. and then a separate PR to move the release note (which won't need a backport, unless we get conflicts in the meantime and I need to resync) |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jul 26, 2021
… data frame with bool indexer
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jul 26, 2021
simonjayhawkins
added a commit
that referenced
this pull request
Jul 26, 2021
simonjayhawkins
added a commit
that referenced
this pull request
Jul 26, 2021
…e with bool indexer (#42728) Co-authored-by: Shoham Debnath <[email protected]>
sthagen
added a commit
to sthagen/pandas-dev-pandas
that referenced
this pull request
Jul 26, 2021
DOC: move release note PR pandas-dev#42644 (pandas-dev#42730)
debnathshoham
added a commit
to debnathshoham/pandas
that referenced
this pull request
Jul 27, 2021
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyErrorwhen assigning to Series values after pop from DataFrame #42530