TST/BLD: add proper skips for bad bs4 version #4259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
O_o travis DL speeds are double digits...so slow... |
|
@jreback this ok? just adding bs4 and html5lib to travis python26 build so that we can verify 4.2.0 tests are in fact being skipped. also adds skip messages for things not found |
|
yes...this looks ok |
cpcloud
added a commit
that referenced
this pull request
Jul 16, 2013
TST/BLD: add proper skips for bad bs4 version
|
i see 0.12 on the horizon 🌅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure things are being properly skipped because of a bad bs4 version.
Also adds a 4.2.0 known bad version of bs4 to 26 travis build so that we can verify that tests are being skipped when the version is bad.