BUG: concat bool+int with ArrayManager #42576
Conversation
jbrockmendel
commented
Jul 16, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| # GH#42092 | ||
| target_dtype = np.find_common_type(list(dtypes), []) | ||
| else: | ||
| target_dtype = find_common_type([arr.dtype for arr in to_concat_no_proxy]) | ||
|
|
There was a problem hiding this comment.
maybe should just modify fond_common_dtyoe itself to handle both cases
There was a problem hiding this comment.
find_common_type has the desired long-term behavior; we need to deprecate the behavior here to match in the future
There was a problem hiding this comment.
i don't understand your comment
There was a problem hiding this comment.
find_common_type is used elsewhere, and we don't want to change the behavior of the other usages. so find_common_type shouldn't be changed.
This is fixing a regression #42092. Eventually we want to change the behavior back to what it is in master, but doing that right will require a deprecation cycle.
lithomas1
added
ArrayManager
Reshaping
|
(this is whats needed to get the CI back to green) |
| # GH#42092 | ||
| target_dtype = np.find_common_type(list(dtypes), []) | ||
| else: | ||
| target_dtype = find_common_type([arr.dtype for arr in to_concat_no_proxy]) | ||
|
|
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
BUG: concat bool+int with ArrayManager (pandas-dev#42576)
Co-authored-by: jbrockmendel <[email protected]>
