Skip to content

DOC: Correct singular "die"/plural "dice" #42574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

drewlevitt
Copy link
Contributor

Minor change to DataFrame.plot.hist documentation: "Dice" is traditionally plural (one die, two dice). Nowadays it can also be singular, but "die" is clearer. "Dices" is simply not a thing.

"Dice" is traditionally plural (one die, two dice). Nowadays it can also be singular, but "die" is clearer. "Dices" is simply not a thing.
@attack68
Copy link
Contributor

I would argue "roll a die" is the correct language for this physical simulation, whereas "draw a number from 1 to 6" is more appropriate for a computational simulation. "draw a die" just seems weird.

change "draw a die" to "roll a die"

Co-authored-by: attack68 <[email protected]>
@jreback jreback added the Docs label Jul 20, 2021
@jreback jreback added this to the 1.4 milestone Jul 20, 2021
@jreback
Copy link
Contributor

jreback commented Jul 20, 2021

looks fine.

@simonjayhawkins simonjayhawkins merged commit efbc1d4 into pandas-dev:master Jul 22, 2021
@simonjayhawkins
Copy link
Member

Thanks @drewlevitt

CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants