Skip to content

ENH: Add support for nullable boolean and integers in Stata writers #42565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Jul 16, 2021

Add code that allows nullable arrays to be written

closes #40855

@bashtage bashtage added Enhancement IO Stata read_stata, to_stata labels Jul 16, 2021
@bashtage bashtage force-pushed the add-nullable-stata branch 3 times, most recently from 129c593 to 680ef1c Compare July 19, 2021 08:02
@bashtage
Copy link
Contributor Author

Seeing a lot of random failures unrelated to this.

@bashtage bashtage force-pushed the add-nullable-stata branch 4 times, most recently from cea5a5c to 03cdbf3 Compare July 21, 2021 15:17
@bashtage bashtage force-pushed the add-nullable-stata branch from 03cdbf3 to f7d7e1b Compare July 29, 2021 15:30
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Aug 29, 2021
@bashtage bashtage force-pushed the add-nullable-stata branch 2 times, most recently from 4c41b64 to b01bbe2 Compare September 1, 2021 13:59
@bashtage
Copy link
Contributor Author

bashtage commented Sep 1, 2021

@jreback I think this is ready, and all green now.

@bashtage bashtage closed this Sep 10, 2021
@bashtage bashtage reopened this Sep 10, 2021
@bashtage bashtage closed this Sep 13, 2021
@bashtage bashtage reopened this Sep 13, 2021
@bashtage bashtage requested a review from jreback September 13, 2021 08:58
@bashtage bashtage closed this Sep 13, 2021
@bashtage bashtage reopened this Sep 13, 2021
@bashtage bashtage removed the Stale label Sep 14, 2021
@jreback jreback added this to the 1.4 milestone Sep 14, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, doc typo. ping on green.

@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

pls merge master as well

Add code that allows nullable arrays to be written

closes pandas-dev#40855
@jreback jreback merged commit 587f1db into pandas-dev:master Sep 14, 2021
@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

thanks @bashtage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Stata read_stata, to_stata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add support for nullable integer columns to StataWriter
2 participants