Skip to content

CLN: clean sqlalchemy import #42546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 28, 2021
Merged

CLN: clean sqlalchemy import #42546

merged 13 commits into from
Jul 28, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jul 15, 2021 •
edited
Loading

xref #40686

fangchenli
fangchenli commented Jul 18, 2021
View reviewed changes
pandas/io/sql.py
Comment on lines -50 to -51
class SQLAlchemyRequired(ImportError):
pass
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@fangchenli fangchenli added IO SQL to_sql, read_sql, read_sql_query Refactor Internal refactoring of code labels Jul 18, 2021
@fangchenli fangchenli marked this pull request as ready for review July 18, 2021 15:52
@jreback jreback added this to the 1.4 milestone Jul 28, 2021
@jreback jreback merged commit 752ee7f into pandas-dev:master Jul 28, 2021
@jreback
Copy link
Contributor

jreback commented Jul 28, 2021

thanks @fangchenli very nice as always!

CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
@fangchenli @CGe0516
CLN: clean sqlalchemy import (pandas-dev#42546)
aaf360b
@fangchenli fangchenli deleted the clean-sqlalchemy-import branch August 17, 2021 04:23
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@fangchenli @feefladder
CLN: clean sqlalchemy import (pandas-dev#42546)
2a98000
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 17, 2022
Closed
3 tasks
@LewisGaul
Copy link

Just a note: this broke our tests where we were passing a mock in as a SQLite conn, which with this change leads to the SQLAlchemy import being attempted. Worked around by setting conn_mock.__class__ = sqlite3.Connection to fool the isinstance() check.

@abowden1989 abowden1989 mentioned this pull request Jan 28, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @jreback @LewisGaul