TYP: Make components of Suffixes Optional #42544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
scravy
changed the title
|
Yes, still interested in this. |
mroeschke
added
Typing
|
@scravy pls merge master and can have a look |
|
Do you prefer rebasing or merging from master? |
|
either are fine |
The documentation on the parameters that actually are of type `Suffixes`: > *suffixeslist-like, default is (“_x”, “_y”)* > A length-2 sequence where each element is optionally a string indicating the suffix to add to overlapping column names in left and right respectively. Pass a value of None instead of a string to indicate that the column name from left or right should be left as-is, with no suffix. At least one of the values must not be None.
|
@jreback I rebased. |
|
thanks @scravy |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Oct 10, 2021
rs2
pushed a commit
to rs2/pandas
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on the parameters that actually are of type
Suffixes: