REF: implement Index._get_indexer_strict #42485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Indexing
jreback
requested changes
Jul 12, 2021
|
|
||
| self._raise_if_missing(keyarr, indexer, axis_name) | ||
|
|
||
| if ( |
There was a problem hiding this comment.
also dt64 and td64. im pretty sure we should actually be doing this (.take on L5416) unconditionally, but that breaks a few tests which i think are wrong, so thats not ready yet
|
|
||
| if nmissing: | ||
|
|
||
| # TODO: remove special-case; this is just to keep exception |
There was a problem hiding this comment.
when we removed IntervalIndex._convert_listlike_indexer we put special-casing here to keep the exception message unchanged. This comment is to remove that special-casing.
|
rebased + greenish |
|
@jreback gentle ping, this unblocks the last 2 MultiIndex PRs on deck |
jreback
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27181, a couple more steps to get that all the way accomplished