ENH: Styler.bar height control #42483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/tests/io/formats/style/test_align.py
jreback
requested changes
Jul 12, 2021
| @@ -2911,7 +2922,13 @@ def css_calc(x, left: float, right: float, align: str): | |||
| else: | |||
| start, end = z_frac, (x - left) / (right - left) | |||
|
|
|||
| return css_bar(start * width, end * width, color) | |||
| ret = css_bar(start * width, end * width, color) | |||
There was a problem hiding this comment.
what happens for height / width out of bounds? do we raise, is this tested?
There was a problem hiding this comment.
currently still renders, but will get bad results. height is a css artifact though so bad CSS just means it gets ignored by the browser.
What do you want to do? Leave as is? Raise on out-of-bounds? or auto trim bad values to be in the range?
There was a problem hiding this comment.
i think raising is appropriate (don't have to do here), prob needs a dedicated PR as likely need to audit all of these.
# Conflicts: # pandas/tests/io/formats/style/test_bar.py
|
can you rebase |
|
done, note the change to keyword only args. |
jreback
approved these changes
Jul 13, 2021
|
thanks, IIRC elsewhere you are going to followon with a check for invalid height? |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought the issue was too complicated to code for such a small feature, but turns out it was only one or two lines of coding, so I added it in. Quite a nice addition for visualisations I think.