BUG: to_xml with index=False and offset input index
#42464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-hesselmann-by
force-pushed
the
fix-xml
branch
4 times, most recently
from
ff3f927 to
6dcba15
Compare
Fixes pandas-dev#42458 It was assumed that the index contains the element `0`. This led to a defect when the index of the input Dataframe has an offset, which is a common use case when streaming Dataframes via generators. This fix consists of not relying on accessing the `0` element of `frame_dicts`.
stephan-hesselmann-by
force-pushed
the
fix-xml
branch
from
6dcba15 to
170ca23
Compare
|
cc @ParfaitG if you can have a look here |
ParfaitG
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Good catch on this issue and good work with this fix, @stephan-hesselmann-by! I have minor comments.
| @@ -290,6 +293,42 @@ def test_index_false_rename_row_root(datapath, parser): | |||
| assert output == expected | |||
|
|
|||
|
|
|||
| def test_index_false_with_offset_input_index(parser): | |||
| """ | |||
There was a problem hiding this comment.
Not sure we annotate reason for test even on bug fixes.
There was a problem hiding this comment.
I can remove the docstring if it goes against coding guidelines for the project. But personally I like to give context to tests like these.
There was a problem hiding this comment.
we normally don't add this, just a comment to the issue. but no harm as you have written it.
ParfaitG
approved these changes
Jul 12, 2021
|
thanks @stephan-hesselmann-by for the patch and @ParfaitG for the review! |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 12, 2021
…fset input index
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jul 13, 2021
… index (#42513) Co-authored-by: Stephan Heßelmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42458
It was assumed that the index contains the element
0. This led to adefect when the index of the input Dataframe has an offset, which is a
common use case when streaming Dataframes via generators.
This fix consists of not relying on accessing the
0element offrame_dicts.to_xmlraisesKeyErrorforindex=Falsewhen the index does not start at zero #42458