Skip to content

BUG: TypeError when shifting DataFrame created by concatenation of slices and fills with values #42453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2021

Conversation

wjsi
Copy link
Contributor

@wjsi wjsi commented Jul 9, 2021

@wjsi wjsi force-pushed the bugfix/concat_shift_fill branch from bd0a93d to e390d17 Compare July 9, 2021 05:30
@wjsi wjsi changed the title BUG: Sampling over selected groupbys does not reflect the selection BUG: TypeError when shifting DataFrame created by concatenation of slices and fills with values Jul 9, 2021
@wjsi wjsi force-pushed the bugfix/concat_shift_fill branch from e390d17 to 8d4ee91 Compare July 9, 2021 06:08
@wjsi wjsi closed this Jul 9, 2021
@wjsi wjsi reopened this Jul 22, 2021
@wjsi wjsi force-pushed the bugfix/concat_shift_fill branch from 8d4ee91 to 9b6155c Compare July 22, 2021 05:52
@wjsi
Copy link
Contributor Author

wjsi commented Jul 22, 2021

I decide to reopen this PR and ignore array manager with reference to test_shift_dt64values_int_fill_deprecated.

@wjsi wjsi force-pushed the bugfix/concat_shift_fill branch from 9b6155c to 73c542d Compare July 26, 2021 02:02
@simonjayhawkins simonjayhawkins added this to the 1.3.2 milestone Jul 26, 2021
@simonjayhawkins simonjayhawkins added Internals Related to non-user accessible pandas implementation Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 26, 2021
@jreback
Copy link
Contributor

jreback commented Jul 26, 2021

looks fine.

cc @jbrockmendel

@wjsi
Copy link
Contributor Author

wjsi commented Jul 27, 2021

@jbrockmendel Done.

@jreback jreback merged commit a1d9c96 into pandas-dev:master Jul 27, 2021
@jreback
Copy link
Contributor

jreback commented Jul 27, 2021

thanks @wjsi

@jreback
Copy link
Contributor

jreback commented Jul 27, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 27, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jul 27, 2021
… concatenation of slices and fills with values (#42754)

Co-authored-by: Wenjun Si <[email protected]>
@wjsi wjsi deleted the bugfix/concat_shift_fill branch July 28, 2021 01:06
CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: TypeError when shifting DataFrame created by concatenation of slices and fills with values
4 participants