Skip to content

CI: Sync all 3.9 builds #42451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

CI: Sync all 3.9 builds #42451

merged 2 commits into from
Jul 9, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 8, 2021 •
edited
Loading

IIUC, all the 3.9 builds(except numpydev) should have all dependencies.

@lithomas1 lithomas1 requested a review from fangchenli July 8, 2021 19:33
@lithomas1 lithomas1 added the CI Continuous Integration label Jul 8, 2021
@lithomas1 lithomas1 added this to the 1.3.1 milestone Jul 8, 2021
@jreback jreback merged commit 87d7855 into pandas-dev:master Jul 9, 2021
@lumberbot-app

This comment has been minimized.

Sign in to view
@jreback
Copy link
Contributor

jreback commented Jul 9, 2021

thanks @lithomas1

@jreback
Copy link
Contributor

jreback commented Jul 9, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app

This comment has been minimized.

Sign in to view
@lithomas1 lithomas1 deleted the patch-1 branch July 9, 2021 15:16
simonjayhawkins
simonjayhawkins reviewed Jul 13, 2021
View reviewed changes
ci/deps/actions-39-slow.yaml
- scipy
- sqlalchemy
- xlrd
- xlsxwriter
- moto
- flask
- numba
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need numba in this env?

Copy link
Member Author

@lithomas1 lithomas1 Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight, PR with fix incoming.

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jul 13, 2021 •
edited
Loading

I think for the backport, will only backport changes in ci/deps/actions-39.yaml and leave ci/deps/actions-39-slow.yaml which maps to ci/deps/actions-37-slow.yaml unchanged.

simonjayhawkins
simonjayhawkins reviewed Jul 13, 2021
View reviewed changes
ci/deps/actions-39.yaml
- scipy
- pyarrow=1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to test against the min version of pyarrow that the pyarrow backed string array supports. backporting this change will still leave pyarrow=1.0.0 in ci/deps/actions-38-locale.yaml on 1.3.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyarrow min is supposed to be bumped to 1.0 in 1.4 if I'm reading #41329 right, so we can probably pin in the minimum versions CI(3.8).

For 1.3.x, I think its fine to leave this out.
P.S. Thanks for the backport by the way.

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jul 13, 2021
@lithomas1 @simonjayhawkins
Backport PR pandas-dev#42451: CI: Sync all 3.9 builds (part)
b8f61c7
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 13, 2021
Merged
jreback pushed a commit that referenced this pull request Jul 13, 2021
@simonjayhawkins @lithomas1
Backport PR #42451: CI: Sync all 3.9 builds (part) (#42515)
e6bdb6c 
Co-authored-by: Thomas Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@fangchenli fangchenli fangchenli approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

CI: update 3.9 packages as they become available
4 participants
@lithomas1 @jreback @simonjayhawkins @fangchenli