Skip to content

DEPS: use importlib for backend discovery #41815 #42410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2021
Merged

DEPS: use importlib for backend discovery #41815 #42410

merged 2 commits into from
Jul 6, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jul 6, 2021 •
edited
Loading

We still use pkg_resources in mpl tests. But it doesn't affect end users.

@jreback jreback added the Build Library building on various platforms label Jul 6, 2021
@jreback jreback added this to the 1.4 milestone Jul 6, 2021
@jreback
Copy link
Contributor

jreback commented Jul 6, 2021

Performing static analysis using mypy
pandas/plotting/_core.py:1763: error: Item "None" of "Optional[Tuple[EntryPoint, ...]]" has no attribute "iter" (not iterable) [union-attr]
pandas/plotting/_core.py:1766: error: Invalid self argument "EntryPoint" to attribute function "load" with type "Callable[[EntryPoint], Any]" [misc]
Found 2 errors in 1 file (checked 1297 source files)
Performing static analysis using mypy DONE

@jreback jreback mentioned this pull request Jul 6, 2021
Closed
@jreback jreback merged commit 8411993 into pandas-dev:master Jul 6, 2021
@jreback
Copy link
Contributor

jreback commented Jul 6, 2021

thanks @fangchenli

@fangchenli fangchenli deleted the use-importlib-eps branch July 7, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

DEPS: clarifying setuptools's status as a dependency
2 participants
@fangchenli @jreback