Skip to content

DOC: Only include numpy.std note for std, not all ddof methods #42290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

TheNeuralBit
Copy link
Contributor

I noticed that this note was mistakenly added to all methods that use num_ddof_doc, e.g. including sem, which is misleading - this statement is only true for std. This PR makes sure we only add the note in that case.

@TheNeuralBit TheNeuralBit force-pushed the docs-numpy-std-notes branch from 9af707e to 8ac245a Compare June 28, 2021 23:31
@mroeschke
Copy link
Member

Sorry for the delay and thanks for the PR. Could you post some screen shots of the doc changes after these changes, especially a method with something after Notes since that newline was removed?

@mroeschke mroeschke added the Docs label Jul 11, 2021
@TheNeuralBit
Copy link
Contributor Author

var (no Note)

image

std (with Note)

image

@mroeschke mroeschke added this to the 1.4 milestone Jul 13, 2021
@mroeschke mroeschke merged commit 3c10f1f into pandas-dev:master Jul 13, 2021
@mroeschke
Copy link
Member

Thanks @TheNeuralBit

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants