Skip to content

TST: Added test for upcasting to object when concatinating on categorical indexes with non-identical categories #42278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 1, 2021
Merged

TST: Added test for upcasting to object when concatinating on categorical indexes with non-identical categories #42278

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd35777
Merge pull request #1 from pandas-dev/master
Jul 27, 2017
7ef9e30
Merge remote-tracking branch 'upstream/master'
Apr 18, 2019
8cd08f3
Merge remote-tracking branch 'upstream/master'
Apr 23, 2019
ead6518
Merge remote-tracking branch 'upstream/master'
Apr 23, 2019
fba7775
Merge branch 'master' of github.com:P-Tillmann/pandas
Oct 23, 2020
5257b3b
Merge remote-tracking branch 'upstream/master'
Oct 23, 2020
f67d132
Merge remote-tracking branch 'upstream/master'
P-Tillmann Nov 2, 2020
4a39e5b
Merge branch 'pandas-dev:master' into master
P-Tillmann Jun 28, 2021
8a45a2e
test upcasting to object when concatinating on categorical indexes wi…
P-Tillmann Jun 28, 2021
ed47241
fixed flake8 issue
P-Tillmann Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pandas/tests/reshape/concat/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,24 @@ def test_categorical_concat_gh7864(self):

dfa = df1.append(df2)
tm.assert_index_equal(df["grade"].cat.categories, dfa["grade"].cat.categories)

def test_categorical_index_upcast(self):
# GH 17629
# test upcasting to object when concatinating on categorical indexes
# with non-identical categories

a = DataFrame({"foo": [1, 2]}, index=Categorical(["foo", "bar"]))
b = DataFrame({"foo": [4, 3]}, index=Categorical(["baz", "bar"]))

res = pd.concat([a, b])
exp = DataFrame({"foo": [1, 2, 4, 3]}, index=["foo", "bar", "baz", "bar"])

tm.assert_equal(res, exp)

a = Series([1, 2], index=Categorical(["foo", "bar"]))
b = Series([4, 3], index=Categorical(["baz", "bar"]))

res = pd.concat([a, b])
exp = Series([1, 2, 4, 3], index=["foo", "bar", "baz", "bar"])

tm.assert_equal(res, exp)