DOC GH29075 close database connections after creation #42277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @TAJD |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 28, 2021
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jun 28, 2021
…tion (#42281) Co-authored-by: Thomas Dickson <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've expanded on the use of a context manager to handle the closing of the database connection after the connection has been opened. I've also included a warning at the end of the section highlighting problems with leaving the database connection open. I think these additions tackle the docs problem associated with this issue.
Whilst psycopg2 is supported through sqlalchemy it appears to not be explicitly supported in its own right. I linked to the section in the sqlalchemy docs which discusses what happens when you use a Python context manager to handle connecting to a database. Hopefully users will now have a better idea on how or why database connections are being made in the recommended manner and can access the relevant documentation quickly.