Skip to content

CLN: Group tests for apply/agg/transform with a string argument #42264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Jun 26, 2021

  • Ensure all linting tests pass, see here for how to run them

Reorg of apply tests, grouping all those that take a string argument together. Plan to next create test_list and test_dict, then all other test files in apply will have (at least partially) UDFs, which make up a majority of the tests.

Had to rename a few tests because of collisions, but otherwise purely a move.

@jreback jreback added Clean Groupby Testing pandas testing functions or related to the test suite labels Jul 1, 2021
@jreback jreback added this to the 1.4 milestone Jul 1, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you rebase and ping on green.

@rhshadrach
Copy link
Member Author

@jreback - greenish

@jreback jreback merged commit f946912 into pandas-dev:master Jul 9, 2021
@rhshadrach rhshadrach deleted the apply_test_str branch July 9, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants