-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: allow label memviews to be None #42260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 31 commits into
pandas-dev:master
from
mzeitlin11:ref/memviews_none_labels
Jul 1, 2021
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c7a91ac
REF: split out sorted_rank algo
mzeitlin11 4b0641e
Fixup docstring
mzeitlin11 b6dd4a6
WIP
mzeitlin11 953b188
WIP
mzeitlin11 254b997
premerge
mzeitlin11 5602dca
Merge remote-tracking branch 'upstream/master' into ref/rank_2d_dedup
mzeitlin11 29dc590
REF: give ranks same nan filling
mzeitlin11 9abd9da
Merge branch 'rank_2d_dedup_chunk' into ref/rank_2d_dedup
mzeitlin11 974650d
WIP
mzeitlin11 b840b74
Handle empty case early
mzeitlin11 f099bb0
Handle empty case early
mzeitlin11 4aa4f8b
WIP
mzeitlin11 c5ed688
WIP
mzeitlin11 7a04159
Add object first test
mzeitlin11 ab9989e
Add back nogil
mzeitlin11 5ba6459
Add whatsnew
mzeitlin11 6154004
Cleaner fused type handling
mzeitlin11 d678bbf
Merge branch 'rank_2d_dedup_chunk' into ref/rank_2d_dedup
mzeitlin11 0f8744d
Add comment
mzeitlin11 d47f2a6
Update whatsnew
mzeitlin11 da61fb8
Try 32-bit fix
mzeitlin11 e2d9617
Debug 32-bit
mzeitlin11 b4d11a4
Debug 32-bit
mzeitlin11 9a94724
Merge remote-tracking branch 'upstream/master' into ref/rank_2d_dedup
mzeitlin11 1e47dae
Move whatsnew
mzeitlin11 8d038af
WIP
mzeitlin11 f90b8d9
Clean up group sizes
mzeitlin11 f70cd30
CLN: allow memviews to be None
mzeitlin11 d9b2342
Fixups
mzeitlin11 c1c741c
Merge remote-tracking branch 'upstream/master' into ref/memviews_none…
mzeitlin11 e92d7c5
array -> asarray and better arg calling
mzeitlin11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as you're shifting these around, can you make everything from here-ish on keyword-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think cdef functions support keyword-only enforced by "*" (unless you have a workaround, I just tried and saw a cython compile error :)
Changed callers to treat it as keyword-only from after mask, though, which should help