-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: create folders in to_csv #24306 #42250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feefladder
commented
Jun 26, 2021
- closes to_csv - allow to create folders. #24306
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
one question would be if we also want this in |
Thanks for the pr @joeperdefloep! Based on the linked issue, it seems like the idea was to add a doc note, and there was no consensus about adding this feature. I'd be surprised by automatic directory creation being the default just based on python behavior, eg
|
Hi @mzeitlin11 thanks for your comment. I know that it would not eb default Python behaviour. My proposed PR is also only an upate in the docs on how to create a new folder so that users can wrap it in a function. #42255 does indeed implement this behaviour and there is discussion there on whether this should be implemented and/or exposed. |
My bad @joeperdefloep, commented on the wrong pr :) |
yeah, actually also slightly mine, should've said take on the issue |
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Few comments here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments and doc build is failing please could you take a look @joeperdefloep
Why are you adding an empty file called |
thanks @joeperdefloep lgtm. @alimcmaster1 @lithomas1 if any comments. |
thanks @joeperdefloep |