BUG: OutOfBoundsTimedelta not raised for out-of-bounds Timedelta #42235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feefladder
commented
Jun 25, 2021
feefladder
commented
- closes BUG: OutOfBoundsTimedelta not raised for out-of-bounds Timedelta #36615
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
jreback
changed the title
jreback
added
Timedelta
| @@ -37,3 +39,9 @@ def test_huge_nanoseconds_overflow(): | |||
| # GH 32402 | |||
| assert delta_to_nanoseconds(Timedelta(1e10)) == 1e10 | |||
| assert delta_to_nanoseconds(Timedelta(nanoseconds=1e10)) == 1e10 | |||
|
|
|||
|
|
|||
| def test_out_of_bounds(): | |||
There was a problem hiding this comment.
this should go in pandas.tests.scalar.timedelta.test_constructors
feefladder
commented
Jun 26, 2021
| @@ -204,15 +204,26 @@ def test_overflow_on_construction(): | |||
| Timedelta(timedelta(days=13 * 19999)) | |||
|
|
|||
|
|
|||
| def test_construction_out_of_bounds_td64(): | |||
There was a problem hiding this comment.
This test was already here and should have caught #36615.
I parametrized it, but this is still a bit puzzling
|
can you merge master |
|
@jbrockmendel ok here |
|
LGTM |
|
thanks @joeperdefloep |
feefladder
added a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.